chore(brillig): Document and test explicit memory limit#11290
Merged
TomAFrench merged 3 commits intomasterfrom Jan 22, 2026
Merged
chore(brillig): Document and test explicit memory limit#11290TomAFrench merged 3 commits intomasterfrom
TomAFrench merged 3 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'ACVM Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 59754c9 | Previous: bb296ff | Ratio |
|---|---|---|---|
perfectly_parallel_batch_inversion_opcodes |
2799589 ns/iter (± 1739) |
2269293 ns/iter (± 1033) |
1.23 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
Resolves #11200
Check out #11200 (comment) and the preceding discussion for more context. Rust has a fundamental per-allocation
isize::MAXlimit.Summary
Changes:
Additional Context
To actually fix the auditor's concern in #11200 about being able to use the full u32 address space, we would most likely need chunked memory. In order to bypass Rust's fundamental allocation limit we would need many smaller Vec fields to cover the full address space. I made a follow-up here #11291 for 1.0+, although I find this to be low priority either way as i32::MAX is a practical limit for the time being.
User Documentation
Check one:
PR Checklist
cargo fmton default settings.