chore: greenlight make_constrain_not_equal for audits
#9535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 08e9bd2 | Previous: 103f70a | Ratio |
|---|---|---|---|
test_report_noir-lang_noir-bignum_ |
455 s |
379 s |
1.20 |
test_report_zkpassport_noir-ecdsa_ |
3 s |
1 s |
3 |
test_report_zkpassport_noir_rsa_ |
2 s |
1 s |
2 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
vezenovm
approved these changes
Sep 3, 2025
compiler/noirc_evaluator/src/ssa/opt/make_constrain_not_equal.rs
Outdated
Show resolved
Hide resolved
compiler/noirc_evaluator/src/ssa/opt/make_constrain_not_equal.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
Resolves #9524
Summary
I copied an explanation of why this pass exists from #7032
Additional Context
I introduced a cSpell regression so to fix it I ran
cSpelllocally and noticed a couple more issues so I decided to fix them here as well as they are very minor changes.Documentation
Check one:
PR Checklist
cargo fmton default settings.