Skip to content

Conversation

jialinli98
Copy link
Contributor

Description

Problem*

Resolves

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

github-actions bot commented Aug 29, 2025

Changes to Brillig bytecode sizes

Generated at commit: be2b79f3d2a8c99efd56c757521c79678df15c31, compared to commit: ed2a32111bb727cc771f8a110ab802d45fd3c130

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
regression_4663_inliner_max -4 ✅ -1.30%
regression_4663_inliner_zero -4 ✅ -1.30%

Full diff report 👇
Program Brillig opcodes (+/-) %
hashmap_inliner_min 8,929 (-33) -0.37%
hashmap_inliner_zero 7,991 (-33) -0.41%
regression_4663_inliner_min 333 (-4) -1.19%
hashmap_inliner_max 18,476 (-232) -1.24%
regression_4663_inliner_max 304 (-4) -1.30%
regression_4663_inliner_zero 304 (-4) -1.30%

Copy link
Contributor

github-actions bot commented Aug 29, 2025

Changes to number of Brillig opcodes executed

Generated at commit: be2b79f3d2a8c99efd56c757521c79678df15c31, compared to commit: ed2a32111bb727cc771f8a110ab802d45fd3c130

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
regression_4663_inliner_max +2 ❌ +0.44%
regression_4663_inliner_zero +2 ❌ +0.44%

Full diff report 👇
Program Brillig opcodes (+/-) %
regression_4663_inliner_max 459 (+2) +0.44%
regression_4663_inliner_zero 459 (+2) +0.44%
hashmap_inliner_min 76,164 (-110) -0.14%
hashmap_inliner_zero 71,898 (-110) -0.15%
hashmap_inliner_max 56,534 (-110) -0.19%

Copy link
Contributor

github-actions bot commented Aug 29, 2025

FYI @noir-lang/developerrelations on Noir doc changes.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 71dc9af Previous: ed2a321 Ratio
test_report_noir-lang_noir_bigcurve_ 398 s 317 s 1.26
test_report_zkpassport_noir-ecdsa_ 3 s 2 s 1.50

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@jialinli98 jialinli98 changed the title chore: map chore: tests for map in stdlib Aug 29, 2025
@TomAFrench
Copy link
Member

There's a lot of new files in here which I'm not sure are intended. main 2.nr, etc.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 11, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 275f7e3 Previous: 548c6f7 Ratio
private-kernel-inner 0.02 s 0.014 s 1.43

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

Copy link
Contributor

github-actions bot commented Sep 11, 2025

@TomAFrench TomAFrench added this pull request to the merge queue Sep 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2025
@jialinli98 jialinli98 added this pull request to the merge queue Sep 12, 2025
Merged via the queue into master with commit 72c8262 Sep 12, 2025
124 checks passed
@jialinli98 jialinli98 deleted the jl/map_test branch September 12, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants