fix: wrong error message in brillig bit shift overflow #9702
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 115e0c8 | Previous: 8fd9446 | Ratio |
|---|---|---|---|
test_report_zkpassport_noir-ecdsa_ |
3 s |
2 s |
1.50 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
|
Should I create a separate issue for why |
No need, I can look at the comptime case as well within the same issue. |
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: aa56321 | Previous: a869373 | Ratio |
|---|---|---|---|
private-kernel-inner |
0.02 s |
0.015 s |
1.33 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 34f6c16 | Previous: fe1ce1d | Ratio |
|---|---|---|---|
rollup-block-root-single-tx |
264 s |
205 s |
1.29 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Description
Problem*
Resolves #9696
Summary*
Brillig and comptime interpreter check for bit shift overflows
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.