Skip to content

feat(ownership): Do not clone indexed call results containing arrays #9791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 9, 2025
Merged

feat(ownership): Do not clone indexed call results containing arrays #9791

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
747ad14
do not clone indexed call results
vezenovm Sep 9, 2025
b149da0
fmt
vezenovm Sep 9, 2025
2f3f525
switch to returning is moved bool from handle_reference_expression
vezenovm Sep 9, 2025
d8f2114
Merge branch 'master' into mv/do-not-clone-index-call-results
vezenovm Sep 9, 2025
00321d5
Update compiler/noirc_frontend/src/ownership/mod.rs
vezenovm Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion compiler/noirc_frontend/src/ownership/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,10 @@ impl Context {
self.handle_reference_expression(&mut index.collection);
self.handle_expression(&mut index.index);

if contains_array_or_str_type(&index.element_type) {
// We do not need to clone the result of a function call.
// The appropriate cloning should be handled by the function internally or the caller of the function.
let is_call = matches!(*index.collection, Expression::Call(_));
if !is_call && contains_array_or_str_type(&index.element_type) {
clone_expr(index_expr);
}
}
Expand Down
Loading