Skip to content

Conversation

asterite
Copy link
Collaborator

@asterite asterite commented Sep 9, 2025

Description

Problem

Resolves #9725

Summary

Check the first two commits as there are two fixes here.

Additional Context

Documentation

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

github-actions bot commented Sep 9, 2025

Changes to Brillig bytecode sizes

Generated at commit: b6ad87e9492ce80dda33ae27916d4f89df5048fd, compared to commit: 8cfbdb9d2cbe21faa883271d3259c726db275ad5

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
regression_1144_1169_2399_6609_inliner_min +3 ❌ +0.30%

Full diff report 👇
Program Brillig opcodes (+/-) %
regression_1144_1169_2399_6609_inliner_min 998 (+3) +0.30%

@asterite asterite requested a review from a team September 9, 2025 19:25
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 8c293bf Previous: 8cfbdb9 Ratio
test_report_zkpassport_noir_rsa_ 2 s 1 s 2

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fairly subtle distinction and took me some time in going through it to make sure it was right. We still need to consider it to be a last_use even if it is used as a reference and not cloned.

@asterite
Copy link
Collaborator Author

asterite commented Sep 9, 2025

@jfecher do you mean there's still something missing here?

@asterite asterite added this pull request to the merge queue Sep 10, 2025
@asterite
Copy link
Collaborator Author

Ah, never mind. Re-reading your comment I understand it better now.

@jfecher
Copy link
Contributor

jfecher commented Sep 10, 2025

Apologies for the unclear wording!

Merged via the queue into master with commit 574550b Sep 10, 2025
123 checks passed
@asterite asterite deleted the ab/assign-ownership-bug branch September 10, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comptime disagrees with Brillig on handling mutable array arguments
2 participants