-
Notifications
You must be signed in to change notification settings - Fork 329
fix(ownership): consider ident in nested l-value as used #9793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changes to Brillig bytecode sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20
.
Benchmark suite | Current: 8c293bf | Previous: 8cfbdb9 | Ratio |
---|---|---|---|
test_report_zkpassport_noir_rsa_ |
2 s |
1 s |
2 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fairly subtle distinction and took me some time in going through it to make sure it was right. We still need to consider it to be a last_use even if it is used as a reference and not cloned.
@jfecher do you mean there's still something missing here? |
Ah, never mind. Re-reading your comment I understand it better now. |
Apologies for the unclear wording! |
Description
Problem
Resolves #9725
Summary
Check the first two commits as there are two fixes here.
Additional Context
Documentation
Check one:
PR Checklist
cargo fmt
on default settings.