-
Notifications
You must be signed in to change notification settings - Fork 329
feat(fuzz): Allow index OOB with a small probability #9803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20
.
Benchmark suite | Current: 42feaba | Previous: d672757 | Ratio |
---|---|---|---|
private-kernel-inner |
0.017 s |
0.013 s |
1.31 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20
.
Benchmark suite | Current: e6ed0e1 | Previous: 2a5315c | Ratio |
---|---|---|---|
test_report_zkpassport_noir_rsa_ |
2 s |
1 s |
2 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would prefer an explicit option to avoid OOB. I don't like it implicitly depending on avoid_overflow and otherwise being random 🤔
Thanks for pointing that out @rkarabut , added a new flag and a |
b6a84b6
to
e6ed0e1
Compare
Description
Problem*
Follow up for #9786
Summary*
With a 1/10 chance leave out the modulo operation that the fuzzer uses to make sure that an arbitrary index will fall into the bounds of an array or slice. This will most certainly result in "Index out of bounds", and the goal is to make sure all backends handle it the same way.
It is only used if
avoid_index_out_of_bounds
isfalse
, which we randomise in fuzz targets so that half the time we don't fall into trivial errors, but give the circuit a chance to complete.Additional Context
This triggered a new bug: #9804
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.