Skip to content

Conversation

vezenovm
Copy link
Contributor

Description

Problem*

Part of greenlighting ACIR gen for audit

Summary*

  1. I made two new modules, brillig_call and call for testing those opcodes
  2. I made some new test scaffolding to enable getting a Program<FieldElement> from an SSA rather than the just the GeneratedAcir artifact as the parser works with the Program type.
  3. Use the SSA and ACIR parser in each test where possible. Some tests were best left on their own such as the operator prop testing or execution failures.

Additional Context

Switching over to use the ACIR parser in fact revealed a bug #9877.

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@vezenovm vezenovm requested a review from a team September 16, 2025 18:56
Copy link
Collaborator

@asterite asterite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@vezenovm vezenovm enabled auto-merge September 16, 2025 19:21
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: cdae8d3 Previous: 0eead18 Ratio
test_report_zkpassport_noir-ecdsa_ 3 s 1 s 3

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@vezenovm vezenovm changed the title chore(acir_gen): Switching existing tests to ACIR gen parser and cleanup test module chore(acir_gen): Switching existing ACIR gen tests to use parser and cleanup test module Sep 16, 2025
@vezenovm vezenovm added this pull request to the merge queue Sep 16, 2025
Merged via the queue into master with commit 8fb7ac5 Sep 16, 2025
126 checks passed
@vezenovm vezenovm deleted the mv/start-switch-of-acir-gen-tests-to-use-parser branch September 16, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants