-
Notifications
You must be signed in to change notification settings - Fork 330
chore(acir_gen): Switching existing ACIR gen tests to use parser and cleanup test module #9878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(acir_gen): Switching existing ACIR gen tests to use parser and cleanup test module #9878
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Co-authored-by: Ary Borenszweig <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20
.
Benchmark suite | Current: cdae8d3 | Previous: 0eead18 | Ratio |
---|---|---|---|
test_report_zkpassport_noir-ecdsa_ |
3 s |
1 s |
3 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Description
Problem*
Part of greenlighting ACIR gen for audit
Summary*
brillig_call
andcall
for testing those opcodesProgram<FieldElement>
from an SSA rather than the just theGeneratedAcir
artifact as the parser works with theProgram
type.Additional Context
Switching over to use the ACIR parser in fact revealed a bug #9877.
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.