Skip to content

Adds add_specs to Api #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adds add_specs to Api #465

wants to merge 3 commits into from

Conversation

thejamesmarq
Copy link

Implements #464

@coveralls
Copy link

coveralls commented Jun 4, 2018

Coverage Status

Coverage remained the same at 96.948% when pulling 883332a on KenSciML:master into 9032694 on noirbizarre:master.

@thejamesmarq
Copy link
Author

Any thoughts on when this might get merged?

@cloud-rocket
Copy link

+1 please merge it. We need it as well. Thanks

@aarondwest
Copy link

@TotempaaltJ Please merge this PR now that it has been approved or is there a different process to get this merged?

@martijnarts
Copy link

Hey @aaronkensci, I'm afraid only the project's collaborators (not me) can merge this PR. You'll have to ask @noirbizarre.

@noirbizarre noirbizarre added this to the 0.12 milestone Aug 21, 2018
@noirbizarre
Copy link
Owner

Sorry for the late response.

Just add a test case (to ensure the feature isn't lost in future refactorings) and I'll merge it ASAP

@noirbizarre noirbizarre modified the milestones: 0.12, 0.13.0 Sep 27, 2018
@avishefi
Copy link

Any plans to merge this?

@lexdevelop
Copy link

Looks like this PR is forgotten :)
There is specific use cases where you can't use reverse proxy and having this exposed is security risk for sure. I can't see any reason to not add such a handy feature. Maybe it will happen in 2023 👍

@j5awry
Copy link
Collaborator

j5awry commented Feb 17, 2020

This project has been abandoned due to lack of release keys. Current maintainers have created an official fork, flask-restx, github python-restx/flask-restx. It is a drop in replacement. If you want any improvements that have been "lost" in the flask-restplus queue, please open a ticket with flask-restx

@lexdevelop
Copy link

Thanks for the info, looks like a lot of developers are not aware of this.

@ziirish
Copy link
Collaborator

ziirish commented Feb 17, 2020

We have pinned an issue about this as well as added some notes at the top of the README.

Do we miss something?

@ziirish
Copy link
Collaborator

ziirish commented Feb 17, 2020

I just gave it a look and unfortunately, we cannot edit the project summary (we only have limited rights to the repo) so I'm afraid we can't do much about it.

Feel free to help us spread the news though and join us at our new place ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants