Add custom ListAndWatch error handler to netwatcher Informer#207
Merged
Conversation
eMGabriel
reviewed
Apr 9, 2020
…m Informer API. When an existing watcher thread fails with an unexpected error, netwatcher will shut itself down. Kubernetes will promptly restart it, re-initializing the watch thus ensuring netwatcher HA. The client provided Informer HA cannot tolerate prolonged API server failures, so this enhancement is an added HA measure on top.
Levovar
force-pushed
the
netwatcher_healthcheck
branch
from
afad00e to
96d91e4
Compare
… queries. Also printing the error messages returend by the netwatcher discovery queries, if any.
Levovar
force-pushed
the
netwatcher_healthcheck
branch
from
96d91e4 to
fc7967d
Compare
Collaborator
Author
|
This might not be what the creators behind the API intended, but it seems to work beautifully |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on recent client enhancement: kubernetes/kubernetes#87329
When an existing watcher thread fails with an unexpected error, netwatcher will shut itself down using this custom handler.
Kubernetes will promptly restart it, re-initializing the watches thus ensuring overall netwatcher HA - even if it comes at the expensive of some Pod restarting..
It is observed that the client library provided Informer HA cannot tolerate prolonged API server failures, so this enhancement makes sure netwatcher always comes back when the API server returns.