Introduce dynamic container interface naming as a fallback option#27
Merged
Conversation
Collaborator
Author
|
TODO1 (reminder for myself :) ) : when Options is provided for a static network only because of container_prefix, host_device and rt_tables are also currently mandated on the schema-level |
Collaborator
Author
|
TODO2: actually the proposed solution does not work :) CNI_IFNAME is an environment level parameter, and is not part of the streamed-in netconf |
Container_prefix API attribute became optional. A NIC connecting to a network having it set will continue to be name accordingly. A NIC connecting to a network not having it set will be dynamically provisioned a Pod-unique name in Pod Instantiation time. Enhancement works for in-built IPVLAN, static delegates, and dynamic delegates!
…voke package, rather than DelegateAdd. This enables separating env variable based configurations on a per-CNI backend basis.
invoke.ExecPluginWithResult unfortunetaly transforms back the CNIArgs into env variables internally. Solution is to inoke RawExec instead.
Levovar
force-pushed
the
dynamic_nic_naming
branch
from
d6dc2c5 to
2516bbd
Compare
…e mandatory parameters anymore).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements solution to #15
Container_prefix API attribute became optional.
A NIC connecting to a network having it set will continue to be name accordingly.
A NIC connecting to a network not having it set will be dynamically provisioned
a Pod-unique name in Pod Instantiation time.
Enhancement works for in-built IPVLAN, static delegates, and dynamic delegates!