Conversation
None, static, dynamic cases are all covered, with al ledge cases. Caught a number of bugs! 1: Last IP from the allocation pool was never used 2: When Pool.End was not provided, we set the first IP into this parameter, rather than the last 3: Static IPs were not validated against the allocation pool
Levovar
changed the title
…served by IPAM are reflected in the DanmNet's alloc bitarray. Checkcan be pre-configured into the stub, and will be automatically invoked during Update REST API call.
All allocation cases are properly covered now.
Collaborator
Author
|
5: Added a new check, explicitly returning an error if an IPv6 address is requested for a subnet smaller than /64 |
Collaborator
Author
|
8: if someone would have changed the allocated IP in a DanmEp to an invalid, or out-of-Cidr-range IP, ipam.Free wold have crashed and paniced |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugs caught and corrected during UTing this package:
1: Last IP from the allocation pool was never used
2: When Pool.End was not provided, we set the first IP into this parameter, rather than the last.
This has resulted in failing validation for a subnet providing only CIDR without allocation pool
3: Static IPs were not validated against the allocation pool
4: When the allocation pool is entirely exhausted, we did not explicitly return an error, but let DANM proceed with setting up an interface without an IP. This has been changed now