Fixing the meaning of "container_prefix" API attribute#78
Merged
Conversation
Currently this API attribute means "exact name of a container" interface, but it was never the original intention. It was just a temporary change when we have moved to the asynchronous provisioning method. Even the name suggest this is just a prefix of the NICs :) Functionally speaking this change was making it hard to attach multiple NICs to the same DanmNet... but nevermore!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently this API attribute means "exact name of a container" interface, but it was never the original intention.
It was just a temporary change I needed to administer when we have moved to the asynchronous interface provisioning method.
Even the name suggest this is just a prefix of the NICs :)
Functionally speaking this makes it hard to attach multiple NICs to the same DanmNet.
After this change implicit and explicit naming schemes will be aligned: in both cases we will postfix the interface names with the provisioning sequence number.