Skip to content

Prevent removing and re-adding of the slideVisibleClass and slideFullyVisibleClass classes #7505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nolimits4web merged 1 commit into from
May 13, 2024
Merged

Prevent removing and re-adding of the slideVisibleClass and slideFullyVisibleClass classes #7505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions src/core/update/updateSlidesProgress.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
const toggleSlideClasses = (slideEl, condition, className) => {
if (condition && !slideEl.classList.contains(className)) {
slideEl.classList.add(className);
} else if (!condition && slideEl.classList.contains(className)) {
slideEl.classList.remove(className);
}
};

export default function updateSlidesProgress(translate = (this && this.translate) || 0) {
const swiper = this;
const params = swiper.params;
Expand All @@ -10,11 +18,6 @@ export default function updateSlidesProgress(translate = (this && this.translate
let offsetCenter = -translate;
if (rtl) offsetCenter = translate;

// Visible Slides
slides.forEach((slideEl) => {
slideEl.classList.remove(params.slideVisibleClass, params.slideFullyVisibleClass);
});

swiper.visibleSlidesIndexes = [];
swiper.visibleSlides = [];

Expand Down Expand Up @@ -54,11 +57,9 @@ export default function updateSlidesProgress(translate = (this && this.translate
if (isVisible) {
swiper.visibleSlides.push(slide);
swiper.visibleSlidesIndexes.push(i);
slides[i].classList.add(params.slideVisibleClass);
}
if (isFullyVisible) {
slides[i].classList.add(params.slideFullyVisibleClass);
}
toggleSlideClasses(slide, isVisible, params.slideVisibleClass);
toggleSlideClasses(slide, isFullyVisible, params.slideFullyVisibleClass);
slide.progress = rtl ? -slideProgress : slideProgress;
slide.originalProgress = rtl ? -originalSlideProgress : originalSlideProgress;
}
Expand Down