[NC? | NSFS] Add support for bucket tagging in NSFS #8234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangledbytes
changed the title
tangledbytes
force-pushed
the
utkarsh/nsfs/bucket-tagging
branch
2 times, most recently
from
72f0810 to
83c0f7b
Compare
guymguym
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
@tangledbytes is there any test coverage for this that we can enable in CI?
guymguym
approved these changes
Aug 1, 2024
tangledbytes
force-pushed
the
utkarsh/nsfs/bucket-tagging
branch
from
83c0f7b to
5def050
Compare
Signed-off-by: Utkarsh Srivastava <[email protected]> use update_config_file instead of direct file write Signed-off-by: Utkarsh Srivastava <[email protected]> add tests for bucket tagging Signed-off-by: Utkarsh Srivastava <[email protected]>
tangledbytes
force-pushed
the
utkarsh/nsfs/bucket-tagging
branch
from
5def050 to
5a5eced
Compare
|
I have added tests here. Merging this PR for now. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
This PR attempts to add support for bucket tagging in NSFS.
The tags are simply stored in the config file for now.
xattrswere also considered for the same purpose but decided against it at least in this iteration as some file systems (eg. AWS EFS) do not support extended attributes.