[NC | NSFS | Glacier] handle ENOENT in _finalize_restore and fix glacier tests not running
#8253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangledbytes
changed the title
_finalize_restoreENOENT in _finalize_restore
guymguym
requested changes
Aug 5, 2024
Signed-off-by: Utkarsh Srivastava <[email protected]> handle ENOENT in open Signed-off-by: Utkarsh Srivastava <[email protected]>
Signed-off-by: Utkarsh Srivastava <[email protected]>
tangledbytes
force-pushed
the
utkarsh/nsfs/fix-finalize-restore-enoent
branch
from
50befa1 to
902aa31
Compare
|
@guymguym, I have added 2 commits in this PR. One PR is the actual fix while the other one fixes the glacier tests not running (my guess since about 3 weeks now). I have split the commits for the ease of backport at least as one would be picked up by DBS3. |
tangledbytes
changed the title
ENOENT in _finalize_restoreENOENT in _finalize_restore and fix glacier tests not running
guymguym
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
This PR simply adds the handler in
_finalize_restoreto make sure that it doesn't errors out if encountersENOENT.Fixes #8251
Testing Instructions:
./node_modules/.bin/mocha src/test/unit_tests/test_nsfs_glacier_backend.js