Add Date.now() to expiry when passing it to Expiration#8254
Merged
Conversation
guymguym
requested changes
Aug 5, 2024
expiry to string to prevent it from being cast to an epoch timeDate.now() to expiry when passing it to Expiration
shirady
reviewed
Aug 6, 2024
shirady
reviewed
Aug 19, 2024
shirady
reviewed
Aug 19, 2024
shirady
reviewed
Aug 19, 2024
shirady
reviewed
Aug 22, 2024
guymguym
requested changes
Aug 25, 2024
guymguym
reviewed
Sep 4, 2024
guymguym
reviewed
Sep 5, 2024
guymguym
requested changes
Sep 5, 2024
guymguym
approved these changes
Sep 9, 2024
guymguym
left a comment
Member
There was a problem hiding this comment.
The code looks ok to me, but did you test it with aws sdk?
Contributor
Author
|
@guymguym - Thanks for the reviews and input, I will make sure to verify it with AWS CLI and fix the unittest prior to merging |
Contributor
Author
|
@guymguym - The PR seems to work great with the AWS CLI, a few points I noticed:
Any chance you already know why that'd happen? |
Signed-off-by: Ben <belimele@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain the changes
Expirationfield in the response toAssumeRolereturned the value in milliseconds; it should be in seconds, and added to the current time; this is now fixedgenerate_session_token()passedexpiryin milliseconds whenmake_auth_tokenexpects seconds, this is now fixed--duration-secondsIssues: Fixed #xxx / Gap #xxx
Testing Instructions:
STS testsection here, observe the return value ofExpiration: