Skip to content

NC | NSFS | Remove Condition Checks Using lodash isUndefined #8267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2024
Merged

NC | NSFS | Remove Condition Checks Using lodash isUndefined #8267

merged 1 commit into from
Aug 7, 2024

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Aug 7, 2024 •
edited
Loading

Explain the changes

  1. Remove condition checks using lodash isUndefined.
    I also validate the implementation of isUndefined in the source (here).

Issues:

  1. Partial fix for NC | Maintenance and Short Refactoring Tasks #8264 .

Testing Instructions:

  1. None (tested in the CI).
  • Doc added/updated
  • Tests added

@shirady shirady self-assigned this Aug 7, 2024
@shirady shirady merged commit 133cbc7 into noobaa:master Aug 7, 2024
10 checks passed
@shirady shirady deleted the nsfs-nc-remove-lodash-isundefined branch August 7, 2024 15:51
@romayalon romayalon mentioned this pull request Aug 7, 2024
Open
10 tasks
@shirady shirady mentioned this pull request Dec 15, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romayalon romayalon romayalon approved these changes

@guymguym guymguym Awaiting requested review from guymguym

@naveenpaul1 naveenpaul1 Awaiting requested review from naveenpaul1

Assignees

@shirady shirady

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shirady @romayalon