Skip to content

NC | NSFS | Remove fs_root Member in BucketSpaceFS and AccountSpaceFS #8268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Aug 8, 2024

Explain the changes

  1. Remove fs_root member in BucketSpaceFS and AccountSpaceFS. Replace it with the original value (empty string '') if it was used.

Issues:

  1. Partial fix for NC | Maintenance and Short Refactoring Tasks #8264

Testing Instructions:

  1. None (tested on CI).
  • Doc added/updated
  • Tests added

1. Remove fs_root member in BucketSpaceFS and AccountSpaceFS. Replace it with the original value (empty string '') if it was used.

Signed-off-by: shirady <[email protected]>
@shirady shirady self-assigned this Aug 8, 2024
@shirady shirady merged commit 68a0cc7 into noobaa:master Aug 8, 2024
10 checks passed
@shirady shirady deleted the nsfs-nc-remove-fs-root-empty-string branch August 8, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants