NC | NSFS | CLI | Update fetch_existing_account_data
#8269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirady
force-pushed
the
nsfs-nc-update-fetch-fetch-existing-account-data
branch
from
84d1fb1 to
eb6aaa6
Compare
naveenpaul1
reviewed
Aug 8, 2024
shirady
force-pushed
the
nsfs-nc-update-fetch-fetch-existing-account-data
branch
from
eb6aaa6 to
b20b907
Compare
naveenpaul1
approved these changes
Aug 8, 2024
1. In the past, for accout update the identifier could be name or access_key, but today it is only name. Therefore, suggesting to remove the other option (get_account_by_access_key ) as it will always use get_account_by_name. Signed-off-by: shirady <[email protected]>
shirady
force-pushed
the
nsfs-nc-update-fetch-fetch-existing-account-data
branch
from
b20b907 to
a7a5c89
Compare
|
@romayalon Moved to draft until we get the answer. |
romayalon
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
get_account_by_access_key) as it will always useget_account_by_name.Issues:
Testing Instructions: