Skip to content

CI | Update Commit Hash in Ceph Tests #8271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Aug 11, 2024

Explain the changes

  1. Update commit hash in Ceph tests.
  2. Move new tests to the pending list (need to investigate):
  • lifecycle_expiration
    s3tests_boto3/functional/test_s3.py::test_lifecycle_expiration_newer_noncurrent
    s3tests_boto3/functional/test_s3.py::test_lifecycle_expiration_size_gt
    s3tests_boto3/functional/test_s3.py::test_lifecycle_expiration_size_lt
  • object_lock
    s3tests_boto3/functional/test_s3.py::test_object_lock_delete_multipart_object_with_retention
    s3tests_boto3/functional/test_s3.py::test_object_lock_delete_multipart_object_with_legal_hold_on
  • bucket_policy
    s3tests_boto3/functional/test_s3.py::test_get_undefined_public_block
    s3tests_boto3/functional/test_s3.py::test_get_public_block_deny_bucket_policy
    Note: we are running more tests (7 tests mentioned above), but still on the same number of passing tests (in Ceph S3 tests for example 313, NSFS Ceph S3 229).

Issues:

We need to update the hash every 180 days - this commit hash will add a few days to the counter (assuming it will be until 23 September 2024).
Note: I cannot update to the latest commit hash because I see many tests that fail when trying to update the commit hash:
ceph_s3:

Aug-11 7:14:48.271 [test_ceph_s3/81] [INFO] CONSOLE:: CEPH TEST SUMMARY: Suite contains 860, ran 312 tests, Passed: 5, Skipped: 6, Failed: 301

nsfs_ceph_s3:

Aug-11 7:14:48.271 [test_ceph_s3/81] [INFO] CONSOLE:: CEPH TEST SUMMARY: Suite contains 860, ran 312 tests, Passed: 5, Skipped: 6, Failed: 301

Testing Instructions:

  1. none (tested through the CI).
  2. If you wish to run it locally:
    make test-cephs3 CONTAINER_PLATFORM=linux/arm64
    make test-nsfs-cephs3 CONTAINER_PLATFORM=linux/arm64
    (I'm using the flag CONTAINER_PLATFORM because I have MacOS M1).
  • Doc added/updated
  • Tests added

@shirady shirady force-pushed the ceph-tests-update-commit-hash branch 3 times, most recently from 70294a2 to 07922fc Compare August 11, 2024 08:39
@shirady shirady marked this pull request as ready for review August 11, 2024 09:09
Copy link
Contributor

@liranmauda liranmauda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Update commit hash in Ceph tests.
Move new tests to the pending list (need to investigate).

Signed-off-by: shirady <[email protected]>
@shirady shirady force-pushed the ceph-tests-update-commit-hash branch from 07922fc to 18a6255 Compare August 11, 2024 09:17
@shirady shirady merged commit 2e73bae into noobaa:master Aug 11, 2024
10 checks passed
@shirady shirady deleted the ceph-tests-update-commit-hash branch August 11, 2024 09:47
@shirady shirady self-assigned this Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants