NC | NSFS | CLI | Improve Performance of List with Name Filter #8272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romayalon
reviewed
Aug 12, 2024
shirady
force-pushed
the
nsfs-nc-list-with-name-filter
branch
from
48926bb to
fa713af
Compare
shirady
changed the title
romayalon
approved these changes
Aug 13, 2024
1. In list_config_files "mock" the entries array to have one entry and it is the name by the filter (for performance). 2. Exclude the action list from fetch_bucket_data and fetch_account_data. 3. Edit the account list tests to validate that we receive an array in the response. Signed-off-by: shirady <[email protected]>
shirady
force-pushed
the
nsfs-nc-list-with-name-filter
branch
from
3981997 to
cd5d80e
Compare
This was referenced Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
list_config_files"mock" the entries array to have one entry and it is the name by the filter (for performance).fetch_bucket_dataandfetch_account_data.Issues:
Testing Instructions:
Unit Tests:
Please run:
sudo npx jest test_nc_nsfs_account_cli.test.js.Manual Tests:
sudo node src/cmd/manage_nsfs account add --name shira-1001 --new_buckets_path /tmp/nsfs_root1 --access_key <access-key> --secret_key <secret-key> --uid <uid> --gid <gid>Note: before creating the account need to give permission to the
new_buckets_path:chmod 777 /tmp/nsfs_root1.sudo node src/cmd/manage_nsfs account list --wide --show_secrets --name <account-name>(should still work).