Skip to content

NC | NSFS | CLI | list_config_files Small Fix #8278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Aug 12, 2024

Explain the changes

  1. list_config_files change function signature (remove unused config_path), and edit JSDoc (add missing type).
  2. Rename the option from should_decrypt to decrypt_secret_key as the destructor of options uses.

Issues:

  1. Currently, when using list we get the encrypted_secret_key instead of secret_key.

Testing Instructions:

  1. Create an account with the CLI: sudo node src/cmd/manage_nsfs account add --name shira-1001 --new_buckets_path /tmp/nsfs_root1 --access_key --secret_key --uid --gid
    Note: before creating the account need to give permission to the new_buckets_path: chmod 777 /tmp/nsfs_root1.
  2. Account list with decryption: sudo node src/cmd/manage_nsfs account list --wide --show_secrets (you will see the property secret_key instead of encrypted_secret_key).
  • Doc added/updated
  • Tests added

@shirady
Copy link
Contributor Author

shirady commented Aug 12, 2024

Backport note - in PR #8192 we change these lines:

const data = type === TYPES.ACCOUNT ?
await config_fs.get_account_by_name(entry.name, options) :
await config_fs.get_bucket_by_name(entry.name, options);

@shirady shirady changed the title NC | NSFS | list_config_files Small Fix NC | NSFS | CLI | list_config_files Small Fix Aug 12, 2024
@shirady shirady self-assigned this Aug 12, 2024
Copy link
Contributor

@romayalon romayalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved
just pls remove the master key warning from the other PR

@shirady shirady force-pushed the nsfs-nc-fix-cli-list branch 2 times, most recently from c21d0ce to d4e01e6 Compare August 12, 2024 10:31
1. list_config_files change function signature (remove unused config_path) and edit JSDoc (add missing type)
2. rename the option from should_decrypt to decrypt_secret_key as the destructor of options uses

Signed-off-by: shirady <[email protected]>
@shirady shirady force-pushed the nsfs-nc-fix-cli-list branch from d4e01e6 to 6268072 Compare August 12, 2024 13:38
@shirady shirady merged commit 906ba38 into noobaa:master Aug 12, 2024
10 checks passed
@shirady shirady deleted the nsfs-nc-fix-cli-list branch August 12, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants