Skip to content

Fixing bucket logging after refactor #8286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

jackyalbo
Copy link
Contributor

@jackyalbo jackyalbo commented Aug 14, 2024

Explain the changes

  1. Adapting the changes to work with containerized and bg_workers and not only NC, bucket_to_owner_keys functions should only get one variable.
  2. Adding the bucket_logging test that was left out probably by mistake
  3. Adding a second test checking the feature e2e for NC - test_nc_bucket_logging

Issues: Fixed #xxx / Gap #xxx

  1. Fixed ODF from not uploading the logs to the target buckets

Testing Instructions:

  • Doc added/updated
  • Tests added

@jackyalbo jackyalbo merged commit 46ccb82 into noobaa:master Aug 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants