Skip to content

NC | NSFS | Docs | Bucket Policy #8287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Aug 15, 2024

Explain the changes

  1. Add bucket policy documentation.
  2. Fix a typo in NooBaa CLI documentation about bucket status - change the argument from "account_name" to "bucket_name".

Issues:

List of GAPs:

  1. Anonymous in our code and example contains the option "Principal": { "AWS": [ "*" ] }, but it is not described in AWS docs (see this documentation the part "Grant anonymous permissions").
  2. Add to the docs this line: "Only the bucket owner can associate a policy with a bucket." (see issue NC | NSFS | Bucket Policy Should Be Managed Only by Bucket Owner #8288 ).

Testing Instructions:

  1. None
  • Doc added/updated
  • Tests added

@shirady shirady self-assigned this Aug 15, 2024
@shirady shirady force-pushed the nsfs-nc-doc-bucket-policy branch from b191cb4 to 3c2fa8a Compare August 15, 2024 05:30
@shirady shirady force-pushed the nsfs-nc-doc-bucket-policy branch 3 times, most recently from 1378426 to 50bddec Compare August 15, 2024 11:41
@shirady shirady requested review from jackyalbo and romayalon August 18, 2024 06:20
@shirady shirady force-pushed the nsfs-nc-doc-bucket-policy branch from cbc5899 to 2e5bfd4 Compare August 19, 2024 14:23
1. Add bucket policy documentation.
2. Fix a typo in NooBaa CLI documentation about bucket status - change the argument from "account_name" to "bucket_name".

Signed-off-by: shirady <[email protected]>
@shirady shirady force-pushed the nsfs-nc-doc-bucket-policy branch from 79ff33e to 6751d81 Compare August 22, 2024 06:42
@shirady shirady merged commit d19fdfd into noobaa:master Aug 22, 2024
10 checks passed
@shirady shirady deleted the nsfs-nc-doc-bucket-policy branch August 22, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants