-
Notifications
You must be signed in to change notification settings - Fork 86
NC | ConfigFS | Create prepare for schema functions and some manage_nsfs refactoring #8297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
romayalon
merged 1 commit into
noobaa:master
from
romayalon:romy-parse-json-and-encrypt-config-fs
Aug 29, 2024
Merged
NC | ConfigFS | Create prepare for schema functions and some manage_nsfs refactoring #8297
romayalon
merged 1 commit into
noobaa:master
from
romayalon:romy-parse-json-and-encrypt-config-fs
Aug 29, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
179ba4d
to
ab255a7
Compare
02d2be9
to
e11f241
Compare
e11f241
to
3a99e8d
Compare
shirady
reviewed
Aug 26, 2024
de92fc6
to
ee4c10b
Compare
shirady
reviewed
Aug 28, 2024
ee4c10b
to
7d17be8
Compare
shirady
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(after adding the changes in discussion)
10 tasks
Signed-off-by: Romy <[email protected]>
9577f95
to
4157448
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
ConfigFS
-CLI
-Issues: Fixed #xxx / Gap #xxx
Testing Instructions: