Skip to content

NC | ConfigFS | Create prepare for schema functions and some manage_nsfs refactoring #8297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented Aug 19, 2024

Explain the changes

  1. ConfigFS -
    1. Created _prepare_for_account_schema() and _prepare_for_bucket_schema() function that prepares a json config file to be written to the config dir.
    2. moved the preparation impl from the callers to the prepare functions called from create/update_account_config_file() and create/update_bucket_config_file().
  2. CLI -
    1. Instead of calling write_stdout_response() from every action in the CLI, called it from the management functions.
    2. Removed account_management() and bucket_management().
    3. Removed old config file preparation code.
    4. moved name/access_key existence check from add_account()/update_account()/add_bucket()/update_bucket() to validate_account_args()/validate_bucket_args() in CLI validations.

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests Updated

@romayalon romayalon force-pushed the romy-parse-json-and-encrypt-config-fs branch from 179ba4d to ab255a7 Compare August 19, 2024 15:00
@romayalon romayalon force-pushed the romy-parse-json-and-encrypt-config-fs branch 5 times, most recently from 02d2be9 to e11f241 Compare August 21, 2024 04:46
@romayalon romayalon requested a review from shirady August 22, 2024 14:35
@romayalon romayalon force-pushed the romy-parse-json-and-encrypt-config-fs branch from e11f241 to 3a99e8d Compare August 26, 2024 11:52
@romayalon romayalon force-pushed the romy-parse-json-and-encrypt-config-fs branch 2 times, most recently from de92fc6 to ee4c10b Compare August 27, 2024 16:36
@romayalon romayalon requested a review from shirady August 28, 2024 06:49
@romayalon romayalon force-pushed the romy-parse-json-and-encrypt-config-fs branch from ee4c10b to 7d17be8 Compare August 28, 2024 14:04
Copy link
Contributor

@shirady shirady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(after adding the changes in discussion)

@romayalon romayalon force-pushed the romy-parse-json-and-encrypt-config-fs branch from 9577f95 to 4157448 Compare August 29, 2024 05:48
@romayalon romayalon merged commit 8f62e5b into noobaa:master Aug 29, 2024
10 checks passed
@romayalon romayalon mentioned this pull request Sep 8, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants