Skip to content

Fix db_cleaner.js to keep updating from_time #8303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

jackyalbo
Copy link
Contributor

@jackyalbo jackyalbo commented Aug 21, 2024

Explain the changes

  1. As part of fixes to md_aggregator and system_store we stopped loading the system_store on every md_aggregator cycle, instead, we added an option to support global_last_update in the system.
  2. As part of this change we missed updating db_cleaner as well with this new structure. Now it was added and from time can advance and allow db_cleaner to run.

Issues: Fixed #xxx / Gap #xxx

  1. Fixed https://bugzilla.redhat.com/show_bug.cgi?id=2305978

Testing Instructions:

  1. Go over the steps in the BZ above and make sure you eventually stop seeing/not seeing any
    waiting for md_aggregator to advance to later than, and you see md_aggregator at keep updating
    like this:
Aug-21 13:38:18.302 [BGWorkers/36]    [L2] core.server.bg_services.db_cleaner:: DB_CLEANER: md_aggregator at 2024-08-21T13:36:17.104Z
Aug-21 13:38:18.303 [BGWorkers/36]    [L0] core.server.bg_services.db_cleaner:: DB_CLEANER: found less than 1000 objects in MD-STORE
Aug-21 13:38:18.305 [BGWorkers/36]    [L0] core.server.bg_services.db_cleaner:: DB_CLEANER: found less than 1000 nodes in nodes-store
Aug-21 13:38:18.306 [BGWorkers/36]    [L0] core.server.bg_services.db_cleaner:: DB_CLEANER: found less than 1000 docs in system-store
Aug-21 13:38:18.306 [BGWorkers/36]    [L0] core.server.bg_services.db_cleaner:: DB_CLEANER: END
Aug-21 13:39:18.310 [BGWorkers/36]    [L0] core.server.bg_services.db_cleaner:: DB_CLEANER: START
Aug-21 13:39:18.310 [BGWorkers/36]    [L2] core.server.bg_services.db_cleaner:: DB_CLEANER: md_aggregator at 2024-08-21T13:37:21.638Z
Aug-21 13:39:18.311 [BGWorkers/36]    [L0] core.server.bg_services.db_cleaner:: DB_CLEANER: found less than 1000 objects in MD-STORE
Aug-21 13:39:18.312 [BGWorkers/36]    [L0] core.server.bg_services.db_cleaner:: DB_CLEANER: found less than 1000 nodes in nodes-store
Aug-21 13:39:18.316 [BGWorkers/36]    [L0] core.server.bg_services.db_cleaner:: DB_CLEANER: found less than 1000 docs in system-store
Aug-21 13:39:18.316 [BGWorkers/36]    [L0] core.server.bg_services.db_cleaner:: DB_CLEANER: END
  • Doc added/updated
  • Tests added

@jackyalbo jackyalbo force-pushed the jacky-db_cleaner_fix branch from ba8a98a to 7a52a4f Compare August 21, 2024 13:55
@jackyalbo jackyalbo merged commit 8b634dd into noobaa:master Aug 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants