Skip to content

NC | Online Upgrade CLI #8308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented Aug 27, 2024

Explain the changes

  1. CLI -

    1. Added upgrade TYPE to noobaa-cli.
    2. Added upgrade - start, status, history actions.
    3. Created upgrade CLI errors, responses, help and validations.
  2. ConfigFS - Added get_system_config_file() function used by status and history actions.

  3. Tests - Added upgrade cli unit tests.

Issues: Fixed #xxx / Gap #xxx

  1. Gap - currently start throws not implemented error - its logic will be added in the PR that implements the upgrade process.
  2. Gap - Documentation will be added after all the PRs are done.
  3. Gap/Idea - Currently on status/history we return the status/history of the config directory upgrade - we can also add --hostname/--all flag for providing the status/history of the RPM upgrade record of a specific host/all hosts.

Testing Instructions:

  • Doc added/updated
  • Tests added

@romayalon romayalon force-pushed the romy-online-upgrade-cli branch 2 times, most recently from 474010e to 19a9e16 Compare August 29, 2024 10:35
Copy link
Contributor

@shirady shirady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of comments and questions

@romayalon romayalon force-pushed the romy-online-upgrade-cli branch 3 times, most recently from cf69229 to a91b64b Compare September 3, 2024 13:15
@romayalon romayalon mentioned this pull request Sep 3, 2024
2 tasks
@romayalon romayalon force-pushed the romy-online-upgrade-cli branch from a91b64b to 68af03b Compare September 4, 2024 14:07
Copy link
Contributor

@shirady shirady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Mostly minor comments - except the one in the manage_nsfs_cli_errors.js so we won't have naming duplication (unless I'm missing something)

@romayalon romayalon force-pushed the romy-online-upgrade-cli branch from 68af03b to 665a502 Compare September 5, 2024 11:01
@romayalon romayalon force-pushed the romy-online-upgrade-cli branch from 665a502 to 5bbc82c Compare September 5, 2024 11:04
@romayalon romayalon merged commit dbe6dab into noobaa:master Sep 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants