-
Notifications
You must be signed in to change notification settings - Fork 86
NC | Online Upgrade CLI #8308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NC | Online Upgrade CLI #8308
Conversation
474010e
to
19a9e16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple of comments and questions
cf69229
to
a91b64b
Compare
a91b64b
to
68af03b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Mostly minor comments - except the one in the manage_nsfs_cli_errors.js
so we won't have naming duplication (unless I'm missing something)
68af03b
to
665a502
Compare
Signed-off-by: Romy <[email protected]>
665a502
to
5bbc82c
Compare
Explain the changes
CLI
-upgrade
TYPE to noobaa-cli.upgrade
-start
,status
,history
actions.ConfigFS
- Added get_system_config_file() function used by status and history actions.Tests
- Added upgrade cli unit tests.Issues: Fixed #xxx / Gap #xxx
start
throws not implemented error - its logic will be added in the PR that implements the upgrade process.--hostname
/--all
flag for providing the status/history of the RPM upgrade record of a specific host/all hosts.Testing Instructions: