Skip to content

NSFS | NC | fix versions_dir_cache validation #8321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2024
Merged

NSFS | NC | fix versions_dir_cache validation #8321

merged 1 commit into from
Sep 9, 2024

Conversation

nadavMiz
Copy link
Contributor

@nadavMiz nadavMiz commented Aug 29, 2024 •
edited
Loading

Explain the changes

  1. change versions_dir_cache validation to check if .versions dir exists before validation
  2. change condition to account for all case of .version dir exists/ don't exists
  3. enable relevant ceph tests

Issues: Fixed #8314

Testing Instructions:

  1. run ceph tests
  • Doc added/updated
  • Tests added

@nadavMiz nadavMiz requested review from romayalon and vh05 August 29, 2024 12:01
romayalon
romayalon reviewed Sep 1, 2024
View reviewed changes
@nadavMiz nadavMiz force-pushed the versioning-validation branch from 38deaf3 to 54eeacf Compare September 9, 2024 15:49
@nadavMiz nadavMiz merged commit bc77785 into noobaa:master Sep 9, 2024
10 checks passed
@nadavMiz nadavMiz deleted the versioning-validation branch September 9, 2024 16:19
@nadavMiz nadavMiz mentioned this pull request Sep 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romayalon romayalon romayalon approved these changes

@vh05 vh05 Awaiting requested review from vh05

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NSFS | S3 | Versioning: Deleting object versions except the latest breaks ListObjectVersions
2 participants
@nadavMiz @romayalon