Skip to content

Encode copy-source in replication utils #8350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tangledbytes
Copy link
Member

Explain the changes

This PR encodes the copy-source in the replication utils. This is to ensure that we encode the keys properly. This being absent results in replication failure, multiple failed GetObject requests (CopySource internally calls this) and failed PutObject requests.

Issues: Fixed #xxx / Gap #xxx

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2277298

Testing Instructions:

  1. make run-single-test testname=test_bucket_replication.js
  • Doc added/updated
  • Tests added

@tangledbytes tangledbytes force-pushed the utkarsh/fix/replication-scanner-url-encode-copy-source branch from a643e2d to 91d2d33 Compare September 11, 2024 14:09
@pull-request-size pull-request-size bot added size/M and removed size/S labels Sep 11, 2024
Signed-off-by: Utkarsh Srivastava <[email protected]>

fix failing tests

Signed-off-by: Utkarsh Srivastava <[email protected]>
@tangledbytes tangledbytes force-pushed the utkarsh/fix/replication-scanner-url-encode-copy-source branch from 91d2d33 to 2b84c69 Compare September 12, 2024 08:05
@tangledbytes
Copy link
Member Author

Manual testing on k8s done. Could successfully replicate an object named 1268-2__#$!@%!#__BED-END-1-Carton-13.jpeg from a namespace store backed bucket to a backing store backed bucket. Merging the PR.

@tangledbytes tangledbytes merged commit 570f843 into noobaa:master Sep 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants