Encode copy-source in replication utils #8350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangledbytes
force-pushed
the
utkarsh/fix/replication-scanner-url-encode-copy-source
branch
from
a643e2d to
91d2d33
Compare
romayalon
approved these changes
Sep 11, 2024
Signed-off-by: Utkarsh Srivastava <[email protected]> fix failing tests Signed-off-by: Utkarsh Srivastava <[email protected]>
tangledbytes
force-pushed
the
utkarsh/fix/replication-scanner-url-encode-copy-source
branch
from
91d2d33 to
2b84c69
Compare
|
Manual testing on k8s done. Could successfully replicate an object named |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
This PR encodes the copy-source in the replication utils. This is to ensure that we encode the keys properly. This being absent results in replication failure, multiple failed GetObject requests (CopySource internally calls this) and failed PutObject requests.
Issues: Fixed #xxx / Gap #xxx
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2277298
Testing Instructions:
make run-single-test testname=test_bucket_replication.js