NSFS | remove previous version external attribute #8351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadavMiz
force-pushed
the
remove-prev-attribute
branch
4 times, most recently
from
f4304c1 to
ba47b08
Compare
|
@nadavMiz could you please add in the PR description the details that you mentioned in the Weekly meeting about the motivation and the reasons for this change? (concurrency issues that it might create so we will have it documented) |
romayalon
approved these changes
Sep 17, 2024
Signed-off-by: nadav mizrahi <[email protected]>
nadavMiz
force-pushed
the
remove-prev-attribute
branch
from
ba47b08 to
6ffaa8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
currently we have external attribute to denote the previous version. it is an optimization to not look for the latest version for promoting the previous version after deleting the latest version. However this is not well maintain and can be wrong on certain concurrency scenarios such as putting multiple objects with the same key at the same time. this can cause that the wrong version is being promoted. so for now remove the previous version external attribute. we should consider returning this xattr in the future if this optimization is necessary.
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: