Skip to content

NC | Add backwards compatibility on get_bucket_owner() for error accuracy #8354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2024
Merged

NC | Add backwards compatibility on get_bucket_owner() for error accuracy #8354

merged 1 commit into from
Sep 12, 2024

Conversation

romayalon
Copy link
Contributor

Explain the changes

  1. Added 'ACCOUNT' type param to get_identity_by_id() for backward compatibility - it was intentionally not added to get_bucket_owner_account() becuase this function is being called only on bucket add/update so we don't really need backwards compatibility here but I added it for not failing on missing account but on the config directory update blocked error on _throw_if_config_dir_locked().
    For more info see - NC | Online Upgrade Process #8326

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

@romayalon romayalon requested a review from shirady September 12, 2024 06:14
shirady
shirady approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@shirady shirady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romayalon romayalon merged commit c21797d into noobaa:master Sep 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirady shirady shirady approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romayalon @shirady