NSFS | GPFS | fix put object over null version in suspended mode #8386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

nadavMiz merged 1 commit into noobaa:master from nadavMiz:put-object-null-suspended

Sep 24, 2024

Contributor

nadavMiz commented Sep 19, 2024 •

edited

Loading

Explain the changes

on Suspeded mode we need to delete the latest null version if a new object is created (as there can be only one object with null version). this delete fails on GPFS since we use the wrong gps_options. however since in GPFS link overrides existing file anyway, we don't need to call unlink at all in such scenario. changed so unlink will not be called to delete latest null version on Suspended mode for GPFS
add missing use of gpfs_options.delete_version instead of gpfs_options for deleting old null version

Issues: Fixed #8379

Testing Instructions:

Run test_nsfs_versioning_gpfs.js tests on gpfs cluster

Doc added/updated
Tests added

nadavMiz requested review from romayalon and shirady

September 19, 2024 11:24

pull-request-size bot added the size/S label

nadavMiz force-pushed the put-object-null-suspended branch from 655be72 to 4a58c0d Compare

September 19, 2024 12:40

romayalon reviewed

View reviewed changes

src/sdk/namespace_fs.js Outdated Show resolved Hide resolved

romayalon reviewed

View reviewed changes

src/sdk/namespace_fs.js Outdated Show resolved Hide resolved

romayalon reviewed

View reviewed changes

src/sdk/namespace_fs.js Outdated Show resolved Hide resolved

romayalon reviewed

View reviewed changes

src/sdk/namespace_fs.js Outdated Show resolved Hide resolved

nadavMiz force-pushed the put-object-null-suspended branch 2 times, most recently from 99ab82c to f944c29 Compare

September 19, 2024 15:21

pull-request-size bot added size/XS and removed size/S labels

nadavMiz force-pushed the put-object-null-suspended branch from f944c29 to 2396533 Compare

September 19, 2024 15:22

romayalon reviewed

View reviewed changes

src/sdk/namespace_fs.js Outdated Show resolved Hide resolved

nadavMiz requested a review from romayalon

September 19, 2024 15:37

nadavMiz force-pushed the put-object-null-suspended branch from 2396533 to 217d311 Compare

September 22, 2024 07:19

pull-request-size bot added size/M and removed size/XS labels

nadavMiz force-pushed the put-object-null-suspended branch 6 times, most recently from d4da795 to ab82fcb Compare

September 24, 2024 07:31

pull-request-size bot added size/S and removed size/M labels

nadavMiz force-pushed the put-object-null-suspended branch from ab82fcb to 4a6197b Compare

September 24, 2024 07:32

romayalon approved these changes

View reviewed changes

nadavMiz force-pushed the put-object-null-suspended branch from 4a6197b to 767070e Compare

September 24, 2024 10:18


          NSFS | GPFS | fix put object over null version in suspended mode

24bd9c4

Signed-off-by: nadav mizrahi <[email protected]>

nadavMiz force-pushed the put-object-null-suspended branch from 767070e to 24bd9c4 Compare

September 24, 2024 10:43

nadavMiz merged commit 00a44f4 into noobaa:master

10 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels