NC | NSFS | Versioning | Headers Check in Unit Tests #8402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirady
force-pushed
the
nsfs-nc-versioning-headers-check
branch
2 times, most recently
from
8b407ef to
d08b89b
Compare
romayalon
approved these changes
Sep 25, 2024
1. In test_bucketspace_versioning.js in the object tagging tests - Add Header check related to HeadObject with tagging, as was manually tested in PR NC | NSFS | Fix Bug | Head Object on a Tagged Object Does Not Return x-amz-tagging-count Header noobaa#8357. - Change the bucket from suspended_bucket_name to bucket_name (the bucket that we use with versioning Enabled). 2. In test_bucketspace_versioning.js add headers check, as was manually tested in PR NC | NSFS | Versioning | Fix Bug | Return 405 for Get/Head Specific Delete-Marker noobaa#8338 in the following tests: - head object, with version enabled, version id specified delete marker - should throw error with code 405 - get object, with version enabled, version id specified delete marker - should throw error with code 405 Signed-off-by: shirady <[email protected]>
shirady
force-pushed
the
nsfs-nc-versioning-headers-check
branch
from
d08b89b to
229a01e
Compare
This was referenced Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
test_bucketspace_versioning.jsin theobject taggingtestsHeadObjectwith tagging, as was manually tested in PR NC | NSFS | Fix Bug | Head Object on a Tagged Object Does Not Returnx-amz-tagging-countHeader #8357.suspended_bucket_nametobucket_name(the bucket that we use with versioning Enabled).test_bucketspace_versioning.jsadd headers check, as was manually tested in PR NC | NSFS | Versioning | Fix Bug | Return 405 for Get/Head Specific Delete-Marker #8338 in the following tests:head object, with version enabled, version id specified delete marker - should throw error with code 405get object, with version enabled, version id specified delete marker - should throw error with code 405Issues:
Testing Instructions:
sudo NC_CORETEST=true node ./node_modules/mocha/bin/mocha ./src/test/unit_tests/test_bucketspace_versioning.js