Skip to content

NSFS | Versioning | Concurrency tests #8405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented Sep 24, 2024

Explain the changes

  1. Added 7 concurrency tests -
    a. concurrent puts & delete latest objects
    b. concurrent puts & delete objects by version id
    c. concurrent delete objects by version id/latest - currently being skipped - there is probably a bug in that flow, Opened an issue - NSFS | Versioning | Concurrent delete latest & delete object by ID which is also the latest  #8414
    d. nested key - concurrent delete multiple objects.
    e. nested key - concurrent puts & deletes.
    f. concurrent puts & list versions
    g. concurrent puts & list versions - version id paging - currently being skipped - there is probably a bug in that flow, opened an issue - NSFS | Versioning | ListObjectVersions | Version ID marker is not working #8406
  2. Fixed indentation and moved up a printing.
  3. Refactored some existing concurrency tests.

Issues: Fixed #xxx / Gap #xxx

  1. Remove the skip from these tests.
  2. List object versions + version id marker not working - NSFS | Versioning | ListObjectVersions | Version ID marker is not working #8406
  3. Delete latest + delete object version id which is also the latest bug - NSFS | Versioning | Concurrent delete latest & delete object by ID which is also the latest  #8414

Testing Instructions:

  1. sudo jest --testRegex=jest_tests/test_versioning_conc
  • Doc added/updated
  • Tests added

@romayalon romayalon force-pushed the romy-concurrency-nested-key branch 2 times, most recently from b6dc71e to f72ae69 Compare September 25, 2024 14:31
@romayalon romayalon requested review from shirady and removed request for shirady September 25, 2024 15:48
@tangledbytes tangledbytes mentioned this pull request Sep 26, 2024
2 tasks
@romayalon romayalon force-pushed the romy-concurrency-nested-key branch 3 times, most recently from 74f339a to aa63ef6 Compare September 26, 2024 12:30
@romayalon romayalon changed the title NC | Versioning | Concurrency tests NSFS | Versioning | Concurrency tests Sep 26, 2024
Copy link
Contributor

@shirady shirady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romayalon romayalon force-pushed the romy-concurrency-nested-key branch from aa63ef6 to 3459797 Compare October 1, 2024 08:41
@romayalon romayalon force-pushed the romy-concurrency-nested-key branch from 3459797 to f84510e Compare October 1, 2024 08:53
@romayalon romayalon merged commit c8c8002 into noobaa:master Oct 1, 2024
10 checks passed
nadavMiz pushed a commit to nadavMiz/noobaa-core that referenced this pull request Oct 1, 2024
…-key

NSFS | Versioning | Concurrency tests
nadavMiz pushed a commit to nadavMiz/noobaa-core that referenced this pull request Oct 6, 2024
…-key

NSFS | Versioning | Concurrency tests
nadavMiz pushed a commit to nadavMiz/noobaa-core that referenced this pull request Oct 7, 2024
…-key

NSFS | Versioning | Concurrency tests
nadavMiz pushed a commit to nadavMiz/noobaa-core that referenced this pull request Oct 7, 2024
…-key

NSFS | Versioning | Concurrency tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants