Lifecycle changes - Allow all actions in put lifecycle configuration #8424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannyzaken
force-pushed
the
danny-fixes
branch
from
c47acef to
c6de06b
Compare
dannyzaken
force-pushed
the
danny-fixes
branch
2 times, most recently
from
43270f2 to
fcf3e1d
Compare
romayalon
reviewed
Oct 1, 2024
| dbg.error('ExpiredObjectDeleteMarker is not implemented, expiration:', expiration); | ||
| throw new S3Error(S3Error.NotImplemented); | ||
| expiration.ExpiredObjectDeleteMarker.length === 1 && | ||
| (/true/i).test(expiration.ExpiredObjectDeleteMarker[0])) { |
There was a problem hiding this comment.
worth putting the regexp in the global scope? due to #7110
| if (rule.Transition) { | ||
| dbg.error('Transition is not implemented, rule:', rule); | ||
| throw new S3Error(S3Error.NotImplemented); | ||
| if (rule.AbortIncompleteMultipartUpload && rule.AbortIncompleteMultipartUpload.length === 1) { |
There was a problem hiding this comment.
style, maybe worth in all the conditions make the conditions easier to read by using ? check -
if (rule?.AbortIncompleteMultipartUpload.length === 1)
| throw new S3Error(S3Error.NotImplemented); | ||
|
|
||
|
|
||
| if (rule.Expiration && rule.Expiration.length === 1) { |
There was a problem hiding this comment.
expiration is still required in the schema, we probably want to remove it if it's not required anymore
same for filter
There was a problem hiding this comment.
Filter is still required. I will remove expiration. thanks
dannyzaken
force-pushed
the
danny-fixes
branch
2 times, most recently
from
387380b to
84a7a68
Compare
romayalon
approved these changes
Oct 1, 2024
* although not all of the actions are implemented in the lifecycle bg worker, we still want to store the provided configuration and not fail it * in NC case, the lifecycle work is performed outside of noobaa, so we want to provide all fields * In addition, for now, allow passing the deprecated Prefix field. This commit leaves a gap regarding validation of the configuration, which should be more aligned with what AWS allows Signed-off-by: Danny Zaken <[email protected]>
dannyzaken
force-pushed
the
danny-fixes
branch
from
84a7a68 to
524869f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: