Skip to content

NC | CLI | Check Access - fix CLI error message #8431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2024
Merged

NC | CLI | Check Access - fix CLI error message #8431

merged 1 commit into from
Oct 6, 2024

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented Oct 6, 2024 •
edited
Loading

Explain the changes

  1. Changed the permissions mentioned in the error message based on the expected FS permissions check when creating account/bucket.

Issues: Fixed #xxx / Gap #xxx

  1. Fixed Need to change the error message during access check failure as noobaa is only checking read (r) access now #8430

Testing Instructions:

  1. As mentioned in the issue.
  • Doc added/updated
  • Tests added

@romayalon romayalon requested a review from shirady October 6, 2024 11:20
shirady
shirady reviewed Oct 6, 2024
View reviewed changes
@romayalon romayalon force-pushed the romy-access-check-fixes branch from 368db14 to 75c0b7f Compare October 6, 2024 12:58
@romayalon romayalon requested a review from shirady October 6, 2024 13:00
shirady
shirady approved these changes Oct 6, 2024
View reviewed changes
Copy link
Contributor

@shirady shirady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romayalon romayalon merged commit bb4a8b3 into noobaa:master Oct 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirady shirady shirady approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to change the error message during access check failure as noobaa is only checking read (r) access now
2 participants
@romayalon @shirady