NC | Online Upgrade events#8670
Merged
Merged
Conversation
b6d1b19 to
c6b6882
Compare
shirady
reviewed
Jan 9, 2025
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
c6b6882 to
7931c7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain the changes
Added online upgrade events on start, success and failure of the config directory upgrade.
For example -
While running the command -
noobaa-cli upgrade start --expected_version 5.18.0 --expected_hosts hostname1the following events will be created on success/failure.1. Start event -
2. Failure event -
3. Success event -
Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
noobaa-cli upgrade start --expected_version 5.18.0 --expected_hosts hostname1when upgrade is valid/invalid.