NC | Lifecycle | Small configuration adjustments/ fixes

[romayalon]

Describe the Problem

Per feedback received in a design meeting adding some changes + tiny CLI fix.

Explain the Changes

1. Changed the following configurations -

config.NC_LIFECYCLE_TIMEOUT_MS = 8 * 60 * 60;
config.NC_LIFECYCLE_RUN_TIME = 00:00;
config.NC_LIFECYCLE_CONFIG_DIR_NAME = 'lifecycle';

2. Moved back the lifecycle cluster lock and the timestamp file to be inside a directory in the config directory which is shared between all the nodes - /etc/noobaa.conf.d/lifecycle/. Initially was the case in 8858 but changed it mistakenly on 8860.
3. Renamed cluster.lock to be lifecycle_cluster.lock.
4. Moved the write_stdout_response/throw_cli_error to manage_nsfs because it was wrongly under the lock and these functions do process.exit(). So changed the order to first release the lock and then write the response to stdout.

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

1. Run noobaa-cli lifecycle and expect to see successful + status
2. Run sudo cat /{path_to_config_path}/lifecycle/lifecycle.timestamp - should contain last lifecycle run timestamp
3. Run sudo cat /{path_to_config_path}/lifecycle/lifecycle_cluster.lock - should be empty
4. Run sudo cat /var/log/noobaa/lifecycle/lifecycle_run_{lifecycle_run_timestamp}.json | jq - should have the status

• Doc added/updated
• Tests added

[nadavMiz]

minor comments