-
Notifications
You must be signed in to change notification settings - Fork 86
NC | lifecycle | add notifications for lifecycle expire #8883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
added comments about minor things we talked about
src/manage_nsfs/nc_lifecycle.js
Outdated
bucket: bucket_json.name, | ||
objects: candidates.delete_candidates | ||
}) | ||
op_func: async () => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't forget to move the _call_op_and_update_status() inside delete_objects_and_send_notifications()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead I created a function to send notifications and kept the delete function as it was before the change.
src/manage_nsfs/nc_lifecycle.js
Outdated
}); | ||
|
||
const writes = []; | ||
for (const deleted_obj of res) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't forget merge logic with lifecycle.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alphaprinz is currently modifying the lifecycle.js code. will leave it separate for now. we can merge it in a different PR
281c22b
to
75ce45e
Compare
Signed-off-by: nadav mizrahi <[email protected]>
75ce45e
to
1b797af
Compare
Describe the Problem
Explain the Changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
manual testing:
s3api create-bucket --bucket test_bucket
nb connection add --name conn --notification_protocol http
s3api put-bucket-notification-configuration --bucket test-bucket --notification-configuration file://notifications.json
s3api put-bucket-lifecycle-configuration --bucket test-bucket --lifecycle-configuration file://lifecycle.json
sudo node src/cmd/manage_nsfs lifecycle --disable_service_validation true --disable_runtime_validation true
NOTIFICATION_LOG_DIR
or setNOTIFICATION_LOG_DIR
in config.jss3api put-bucket-versioning --bucket test-bucket --versioning-configuration Status=Enabled
, before running lifecycle