-
Notifications
You must be signed in to change notification settings - Fork 86
NC | Lifecycle | Health #8893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
NC | Lifecycle | Health #8893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bb2d9bf
to
4a4f3d0
Compare
shirady
reviewed
Mar 24, 2025
29 tasks
shirady
approved these changes
Mar 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nadavMiz
approved these changes
Mar 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Romy <[email protected]>
2a24040
to
b331051
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the Problem
The NC health CLI should report on the latest lifecycle worker run.
Explain the Changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
a. Empty scenario - run
noobaa-cli diagnose health --lifecycle
b. valid scenario -
b.1. run
noobaa-cli lifecycle
3 times.b.2. run
noobaa-cli diagnose health --lifecycle
and expect to have the latest run information.c. error scenario =
c.1. Edit config.json and set NC_LIFECYLE_TIMEOUT_MS to be 1.
c.2. run
noobaa-cli diagnose health --lifecycle
and expect to have the latest run information including the timeout error.