Skip to content

[Backport into 5.18] disable node disconnect on error and detention #8902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

liranmauda
Copy link
Contributor

@liranmauda liranmauda commented Mar 26, 2025

Explain the Changes

  • Added config.NODES_DISCONNECT_ON_ERROR which is false by default.
  • In nodes_monitor. report_error_on_node_blocks, disconnect the node only if config.NODES_DISCONNECT_ON_ERROR is true.
  • Changed the default of NODE_IO_DETENTION_DISABLE to true. Most users usually have a single node in a pool, so putting a node into detention causes many issues.

Signed-off-by: Danny Zaken [email protected]
(cherry picked from commit e5754e7)

Fixes:

- Added `config.NODES_DISCONNECT_ON_ERROR` which is false by default.
- In `nodes_monitor. report_error_on_node_blocks`, disconnect the node only if config.NODES_DISCONNECT_ON_ERROR is true.
- Changed the default of NODE_IO_DETENTION_DISABLE to true. Most users usually have a single node in a pool, so putting a node into detention causes many issues.

Signed-off-by: Danny Zaken <[email protected]>
(cherry picked from commit e5754e7)
@liranmauda liranmauda merged commit 79a7eb7 into noobaa:5.18 Mar 26, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants