Skip to content

NC | Delete object filter verification on regular delete object #8950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented Apr 8, 2025

Describe the Problem

On NC lifecycle - getting the deletion candidates might take a lot of time (especially when using GPFS optimization), therefore we should re-check the filter and expiration before deleting the object.

Explain the Changes

  1. NCLifecycle - Since we call delete_multiple_objects per rule - passed the filter func to the delete_multiple_objects function.
  2. NamespaceFS - Changed delete_multiple_objects to delete based on file descriptors if the flow is gpfs/lifecycle_deletion + apply the filter func and check if we should still delete the object. if not - throw an error.
  3. refactoring - moved some functions to utils so they can be used by both NCLifecycle and NamespaceFS.

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  1. sudo jest --testRegex=jest_tests/test_nc_lifecycle_posix
  2. sudo jest --testRegex=jest_tests/test_nc_lifecycle
  • Doc added/updated
  • Tests added

@romayalon romayalon force-pushed the romy-delete-object-verification branch 7 times, most recently from 62ad81f to 7a67731 Compare April 14, 2025 14:27
@romayalon romayalon requested a review from nadavMiz April 14, 2025 16:27
@romayalon romayalon force-pushed the romy-delete-object-verification branch from 17ce220 to b7184c0 Compare April 14, 2025 17:04
@romayalon romayalon force-pushed the romy-delete-object-verification branch from a5af3f9 to 5946d0c Compare April 15, 2025 13:47
@romayalon romayalon force-pushed the romy-delete-object-verification branch 7 times, most recently from 94bd865 to e17e36f Compare April 28, 2025 17:31
@romayalon romayalon requested a review from nadavMiz April 28, 2025 17:34
@romayalon romayalon force-pushed the romy-delete-object-verification branch from e17e36f to 1b2d3fd Compare April 29, 2025 06:53
Copy link
Contributor

@nadavMiz nadavMiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…te marker and version id deletion is not implemented yet)

Signed-off-by: Romy <[email protected]>
@romayalon romayalon force-pushed the romy-delete-object-verification branch from 1b2d3fd to 2c7d076 Compare April 29, 2025 08:12
@romayalon romayalon merged commit 086fd04 into noobaa:master Apr 29, 2025
11 checks passed
@romayalon romayalon mentioned this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants