NC | lifecycle | add expire delete marker rule

[nadavMiz]

Describe the Problem

added expire delete marker rule. see https://docs.aws.amazon.com/AmazonS3/latest/userguide/lifecycle-configuration-examples.html#lifecycle-config-conceptual-ex7

Explain the Changes

1. add expire delete marker rule
2. in case last item is a delete marker, change the state to start from this delete marker in the next run

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

1. sudo npx jest test_nc_lifecycle_cli

• Doc added/updated
• Tests added

[romayalon]

when having an expired delete marker we don't care if there is also expiration by days/date?

[nadavMiz]

its a separate rule than both of them. also I think you can't even put expired delete marker and days/date together

[romayalon]

hmm IIRC if days is set then automatically expired delete marker = true, right?
does it mean that the expired delete marker is on objects that passed the expiration days?

[nadavMiz]

according to aws:

You can't specify both a Days and an ExpiredObjectDeleteMarker tag on the same rule. When you specify the Days tag, Amazon S3 automatically performs ExpiredObjectDeleteMarker cleanup when the delete markers are old enough to satisfy the age criteria. To clean up delete markers as soon as they become the only version, create a separate rule with only the ExpiredObjectDeleteMarker tag.

so I guess you are correct. I'll change this

[romayalon]

and expire date + expire delete marker based on aws?

[nadavMiz]

trying to put date and expire delete marker together returns MalformedXML error. there is nothing on AWS documentation about about implicit ExpiredObjectDeleteMarker when having date rule. so I guess we can't have both of them together