Skip to content

NC | CI | fix lifecycle timeout flaky test #8971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

romayalon
Copy link
Contributor

Describe the Problem

Some jest tests seem to be flaky, this is a trial to fix one of them that is named - lifecycle_cli - change timeout to 1 ms - should fail

Explain the Changes

  1. This test is flaky because there were no buckets/objects to process and sometimes the lifecycle worker succeeded, in order to make sure it'll always fail on timeout - added 2 buckets that will need to be read during the lifecycle process, therefore the timeout will always hit.

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  1. Run sudo jest --testRegex=jest_tests/test_nc_lifecycle_cli --t "lifecycle_cli - change timeout to 1 ms - should fail" multiple times
  • Doc added/updated
  • Tests added

@romayalon romayalon force-pushed the romy-flaky-timeout-test branch from c0cbea0 to 97c6e11 Compare April 14, 2025 17:03
@romayalon romayalon merged commit 20d8f05 into noobaa:master Apr 15, 2025
11 of 12 checks passed
@romayalon romayalon mentioned this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants