Skip to content

NC | lifecycle | Add Tests in POSIX Integration Tests - Part 3 #9001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2025

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Apr 29, 2025

Describe the Problem

We want to expand our test coverage in the NC lifecycle.

Explain the Changes

  1. Add tests related to versioning SUSPENDED based on the tests that we had in versioning ENABLED.
  2. Rename the titles versioning ENABLE to versioning ENABLED.
  3. Remove redundant set_bucket_versioning as it is set in the beforeAll.
  4. Move the test nc lifecycle - noncurrent expiration rule - expire versioning enabled bucket - regular key under the describe of describe noobaa nc - lifecycle versioning ENABLED directly and rename it to nc lifecycle - expiration rule - expire versioning ENABLED bucket - regular key.
  5. Copy the new tests that were added in PR NC | lifecycle | add noncurrent days rule #8992 and run them when the bucket is in versioning SUSPENDED, edit the "id" in the rule in those tests to match them, and edit the comments so it would be clearer.
  6. Edit the titles of the test to have versioning ENABLED / SUSPENDED in them.

Issues:

  1. GAPS - we still have more tests that we plan to add to improve our coverage.

Testing Instructions:

Automatic Tests

  1. Please run: sudo npx jest test_nc_lifecycle_posix_integration
  • Doc added/updated
  • Tests added

@shirady shirady self-assigned this Apr 29, 2025
@shirady shirady requested review from nadavMiz and romayalon April 29, 2025 12:11
@shirady shirady force-pushed the nc-nsfs-lifecycle-tests-part-3 branch from 19696f6 to 7fffa8b Compare April 30, 2025 08:18
@shirady shirady marked this pull request as draft April 30, 2025 08:44
@shirady shirady marked this pull request as ready for review April 30, 2025 09:35
@shirady shirady force-pushed the nc-nsfs-lifecycle-tests-part-3 branch from 03940fa to cb58ff0 Compare May 4, 2025 08:02
@shirady shirady requested a review from nadavMiz May 4, 2025 10:41
Copy link
Contributor

@nadavMiz nadavMiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirady shirady force-pushed the nc-nsfs-lifecycle-tests-part-3 branch from 82c39f9 to d5d5258 Compare May 4, 2025 11:08
@shirady shirady merged commit e558970 into noobaa:master May 4, 2025
11 checks passed
@shirady shirady deleted the nc-nsfs-lifecycle-tests-part-3 branch May 4, 2025 11:38
@romayalon romayalon mentioned this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants