Skip to content

NC | lifecycle | Small GPFS flow fixes #9006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

NC | lifecycle | Small GPFS flow fixes #9006

merged 1 commit into from
May 5, 2025

Conversation

romayalon
Copy link
Contributor

Describe the Problem

This PR aims to fix some small issues found while working on manual tests of lifecycle GPFS flow.

Explain the Changes

  1. size is a number - can be 0 - therefore we should check if it's undefined and not if truthy.
  2. bucket name having dots/dash or others caused mmapply policy issues without ''.
  3. parse_candidates_from_gpfs_ilm_policy() - if there were no candidates we accidently returned undefined instead of an empty array.

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

@romayalon romayalon requested a review from nadavMiz May 4, 2025 17:20
@romayalon romayalon force-pushed the romy-nc-lifecycle-gpfs-fixes branch from eca1867 to d591e41 Compare May 4, 2025 17:43
@pull-request-size pull-request-size bot added size/S and removed size/XS labels May 4, 2025
@romayalon romayalon changed the title NC | lifecycle | small GPFS flow fixes NC | lifecycle | Small GPFS flow fixes May 5, 2025
@romayalon romayalon merged commit 3eec299 into noobaa:master May 5, 2025
11 of 12 checks passed
@romayalon romayalon mentioned this pull request May 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadavMiz nadavMiz nadavMiz approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romayalon @nadavMiz