IAM backports to 5.18.4 #9038
Merged
IAM backports to 5.18.4 #9038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shirady <[email protected]> (cherry picked from commit 3268fff)
1. Rename the file and actions related to GetBucketRequestPayment and add a log printing so we will not fail the request, also add a test for the mock in containerized and NC. 2. Rename the file and actions related to PutBucketRequestPayment in the same way. Signed-off-by: shirady <[email protected]> (cherry picked from commit e0f0922)
1. By default, we will fail the request with ServerSideEncryptionConfigurationNotFoundError, aligned with PR Changing get bucket encryption defaults noobaa#8716 . 2. Edit existing unit tests in test_bucketspace_fs.js. 3. Not related to NC changes: - Add a test (only runs in containerized). - Improve docs related to running core_tests locally. Signed-off-by: shirady <[email protected]> (cherry picked from commit 811c88c)
…for-user) Signed-off-by: shirady <[email protected]> (cherry picked from commit 43ff894)
nimrod-becker
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the Problem
Explain the Changes
This PR backports the following PRs to 4.18.4 -
NotImplemented#8903GetBucketRequestPayment#8924get_bucket_encryptionto Return Object #8927list-group-for-user) #8920Issues: Fixed #xxx / Gap #xxx
Testing Instructions: