Clear connection map on clean up. (dfs 2834) #9111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe changes update the "node-rdkafka" dependency in Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant KafkaNotificator
participant KafkaBroker
Client->>KafkaNotificator: connect()
KafkaNotificator->>KafkaBroker: Initiate connection
KafkaBroker-->>KafkaNotificator: Connection result (success/failure)
KafkaNotificator->>KafkaNotificator: Log connection status
Client->>KafkaNotificator: promise_notify(notification)
KafkaNotificator->>KafkaBroker: Send notification
KafkaBroker-->>KafkaNotificator: Delivery report (success/failure)
KafkaNotificator->>KafkaNotificator: Log send result
Client->>KafkaNotificator: destroy()
KafkaNotificator->>KafkaNotificator: Check if connected
KafkaNotificator-->>KafkaBroker: flush & disconnect (if connected)
KafkaNotificator->>KafkaNotificator: Log destruction status
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
npm error Exit handler never called! 📜 Recent review detailsConfiguration used: .coderabbit.yaml ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (4)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
the
Enable-Auto-Rebase
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/labeler.yml (1)
1-2: GitHub labeler configuration looks good but consider more specific rules.The configuration will automatically apply the
Enable-Auto-Rebaselabel to all PRs since the regex.*matches any branch name. This may be intentional for this repository's workflow.Consider if you want more specific labeling rules based on branch patterns:
Enable-Auto-Rebase: - - head-branch: '.*' + - head-branch: '^(feature|bugfix|hotfix)/.*'
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (4)
.github/labeler.yml(1 hunks).github/workflows/autolabel-prs.yml(1 hunks)package.json(1 hunks)src/util/notifications_util.js(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: build-noobaa-image
- GitHub Check: run-jest-unit-tests
- GitHub Check: run-package-lock-validation
- GitHub Check: Summary
🔇 Additional comments (6)
package.json (1)
110-110: ```shell
#!/bin/bash
npm view node-rdkafka versions --json
npm view [email protected] version</details> <details> <summary>.github/workflows/autolabel-prs.yml (1)</summary> `1-18`: **GitHub Actions workflow for PR labeling is well-configured.** The workflow uses appropriate triggers, permissions, and actions versions. Using `pull_request_target` is correct for this use case as it allows the workflow to run with write permissions on external PRs. </details> <details> <summary>src/util/notifications_util.js (4)</summary> `109-110`: **LGTM! Connection map cleanup addresses the core issue.** This change correctly implements the PR objective to clear the connection map during cleanup, preventing reuse of stale connections in containerized environments. The order is appropriate - clearing `connect_str_to_connection` before `notif_to_connect`. --- `276-294`: **Enhanced Kafka connection logging improves troubleshooting.** The additional debug logging provides better visibility into the Kafka connection lifecycle, including connection attempts, success/failure events, and error handling. --- `307-315`: **Improved callback signature and notification logging.** The callback signature was simplified by removing the unused `offset` parameter, and additional debug logging helps track notification success/failure with connection details. --- `321-325`: **Connection state check prevents unnecessary operations.** Adding `isConnected()` check before calling `flush()` and `disconnect()` prevents potential errors when the connection is already inactive, improving robustness. </details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
alphaprinz
force-pushed
the
notif_dfs2834
branch
from
d61c5fc to
5f9de81
Compare
alphaprinz
force-pushed
the
notif_dfs2834
branch
from
5f9de81 to
2cef7cd
Compare
jackyalbo
approved these changes
Jun 23, 2025
…lso add logs, bump version Signed-off-by: Amit Prinz Setter <[email protected]>
Neon-White
force-pushed
the
notif_dfs2834
branch
from
2cef7cd to
7226ecb
Compare
alphaprinz
added a commit
to alphaprinz/noobaa-core
that referenced
this pull request
Jun 23, 2025
…lso add logs, bump version (noobaa#9111) Signed-off-by: Amit Prinz Setter <[email protected]>
This was referenced Jun 23, 2025
alphaprinz
added a commit
to alphaprinz/noobaa-core
that referenced
this pull request
Jun 24, 2025
…lso add logs, bump version (noobaa#9111) Signed-off-by: Amit Prinz Setter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the Problem
When Notificator is done, it should clean the map containing the connections established during it's run.
Otherwise these stale connection would be used in the next run.
This scenario is relevant only to containerized (ie, does not affect NC).
Also-
-add more logs
-bump version 3.4.0 -> 3.4.1
Explain the Changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
Summary by CodeRabbit
Bug Fixes
Chores
Style