Bumping deps to avoid CVE (13/11/2025) (part 2)#9305
Conversation
WalkthroughBumped dependency versions in Changes
Sequence Diagram(s)(omitted — changes are dependency/version updates only; no control-flow changes) Estimated code review effort🎯 2 (Simple) | ⏱️ ~5–10 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(2 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: Neon-White
Repo: noobaa/noobaa-core PR: 9229
File: .github/workflows/ibm-nightly-provision-dispatcher.yaml:13-13
Timestamp: 2025-09-30T08:56:55.478Z
Learning: In the noobaa-core repository, PR #9229 (nightly IBM VM provision dispatcher) has a dependency on `.github/ibm-warp-runner-config.yaml` which is provided in PR #9230, requiring PR #9230 to be merged first.
📚 Learning: 2025-09-30T10:27:57.996Z
Learnt from: Neon-White
Repo: noobaa/noobaa-core PR: 9230
File: tools/ibm_runner_helpers/slack_notifier.js:4-4
Timestamp: 2025-09-30T10:27:57.996Z
Learning: In the noobaa-core repository, the `tools/ibm_runner_helpers/slack_notifier.js` script depends on `slack/webhook`, which is installed globally via `npm -g install 'slack/webhook'` in `.github/ibm-warp-runner-config.yaml` (cloud-init configuration) rather than being declared in package.json, since the script runs on IBM Cloud VMs provisioned by cloud-init.
Applied to files:
package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: run-jest-unit-tests
- GitHub Check: run-package-lock-validation
- GitHub Check: Build Noobaa Image
🔇 Additional comments (2)
package.json (2)
75-84: Test dependency updates to ensure functionality and CVE resolution.After bumping these dependencies, ensure that:
- The application builds and starts without errors.
- S3, STS, and storage operations function correctly with the new SDK versions.
- The specific CVEs targeted in this update are confirmed as resolved.
Consider running the test suite (lint, mocha, jest) against these changes to catch any regressions early.
75-79: Verify AWS SDK package version consistency and confirm CVE references.The git diff shows AWS SDK packages upgraded from 3.893.0 to mixed versions:
client-s3,lib-storage, ands3-request-presignerat 3.937.0, whileclient-stsandcredential-providersremain at 3.936.0. Confirm whether this version split is intentional or should be aligned.Additionally, your commit message references "(part 2)" but provides no specific CVE identifiers or details. The release notes for v3.936.0 and v3.937.0 do not list security fixes. Clarify which specific CVEs you are addressing and provide a reference to the corresponding "part 1" PR or security advisory to ensure these versions actually contain the necessary fixes.
Also applies to: line 129 (
@aws-sdk/client-iamat 3.936.0)
700a6d7 to
9b6b8fa
Compare
- Bumping deps to avoid CVE (13/11/2025) (part 2) Signed-off-by: liranmauda <liran.mauda@gmail.com>
9b6b8fa to
5e53011
Compare
Explain the Changes
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.